Skip to content

Improve Layer and Link type support - #405

Merged
phoenixy1 merged 3 commits into
masterfrom
improve/product-link-types
Jul 23, 2026
Merged

Improve Layer and Link type support#405
phoenixy1 merged 3 commits into
masterfrom
improve/product-link-types

Conversation

@phoenixy1

@phoenixy1 phoenixy1 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Layer's submission flow and newer Link callbacks are not fully represented in the React SDK types.

This corrects Layer submission and callback types, adds current stable events and metadata, strongly types the hook result, and adds a complete Layer example.

@phoenixy1

Copy link
Copy Markdown
Collaborator Author

claude review:

One minor, non-blocking finding survived verification:

  • src/types/index.ts:187 — PlaidLinkResult duplicates PlaidFactory's open/submit/exit signatures instead of deriving from it (e.g. Omit<PlaidFactory, 'destroy'> & {error, ready}). (PLAUSIBLE) The duplication is real, but fixing it would
    require types/index.ts to import from factory.ts, which already imports from types/index.ts — a circular import. TS can often tolerate type-only circular imports, so this is a judgment call rather than a clear-cut fix, and low severity since
    both signatures are currently identical.

Overall the PR looks solid — no confirmed correctness bugs.

@phoenixy1
phoenixy1 requested a review from dtroupe-plaid July 23, 2026 22:25
dtroupe-plaid
dtroupe-plaid previously approved these changes Jul 23, 2026

@dtroupe-plaid dtroupe-plaid left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/layer.tsx
}
}, []);

// Initialize Link as soon as the view mounts so Layer can preload.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@phoenixy1
phoenixy1 merged commit f75644a into master Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants